Fix IDOR: Validate pinned_post belongs to account#60
Open
bellisabell wants to merge 1 commit intomainfrom
Open
Fix IDOR: Validate pinned_post belongs to account#60bellisabell wants to merge 1 commit intomainfrom
bellisabell wants to merge 1 commit intomainfrom
Conversation
Fixes #20 Added model-level validation to ensure pinned_post_id can only be set to a post that belongs to the current account. Previously, account_params permitted :pinned_post_id without any ownership check, allowing attackers to pin posts from other accounts. Security: HIGH - Prevents cross-account post pinning vulnerability.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #20 - Security: IDOR - Cross-account post pinning vulnerability
Problem
account_paramsinAccountControllerpermits:pinned_post_idbut never validates that the post actually belongs to the current account. This allows an attacker to pin any post from any account by manipulating thepinned_post_idparameter.Solution
Added a model-level validation
pinned_post_belongs_to_accountthat ensures:pinned_post_idis set, it must reference a post owned by the accountposts.exists?(id: pinned_post_id)to verify ownershipThis is implemented at the model level (rather than controller) to ensure the validation applies regardless of how the account is updated.
Severity
HIGH - This is an IDOR vulnerability that could expose private/unlisted posts from other accounts.