CPP changes #83
Merged
CPP changes #83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
coot
commented
Jun 22, 2025
coot
commented
- CPP: use MIN_VERSION_GHC or MIN_VERSION_GLASGOW_HASKELL
- ghc-tags-plugin: let Lukko decide on the file lock implementation
- ghc-tags-core: fixed darwin's CPP macro
- ghc-tags-core: removed CPP for GHC-9.2 or below.
- GHC warnings
On Darwin, as on Posix, `\n` is the new line character. It worked, only because the CPP was broken 😁.
We no longer support it.
We still explicitly add `-Wpartial-fields`, it's not part of `-Wall` for `GHC > 9.8`
coot
force-pushed
the
coot/cpp
branch
2 times, most recently
from
3ab883b to
cfd8e2c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.