-
Notifications
You must be signed in to change notification settings - Fork 26
Update release ISSUE_TEMPLATE #1137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
tlbueno
commented
Oct 1, 2025
- Update the graph urls to use oci
- Update previous version verification to remove the parent commit
yasminvalim
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/LGTM
|
I think we should change the graph tool to query the OCI graph by default rather than changing all the urls here |
Now that we are defaulted to OCI updates and are no longer shipping OSTree commits to the repo, let's show the OCI graph by default. Prompted by coreos/fedora-coreos-streams#1137
4920111 to
c16bab0
Compare
Yes, that is better. I just updated this PR to change only the parent version verification. |
Now that we are defaulted to OCI updates and are no longer shipping OSTree commits to the repo, let's show the OCI graph by default. Prompted by coreos/fedora-coreos-streams#1137
- Update previous version verification to remove the parent commit Signed-off-by: Tiago Bueno <[email protected]>
c16bab0 to
42e8531
Compare
|
|
||
| Using the [the build browser for the `next` stream](https://builds.coreos.fedoraproject.org/browser?stream=next): | ||
|
|
||
| - Verify that the parent commit and version match the previous `next` release (in the future, we'll want to integrate this check in the release job) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/match/matches
before it was two things that need to match
now it's just one thing and I think that means it should be matches, but I'm no grammar expert, for sure.
dustymabe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One suggestion. LGTM
marmijo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM other than Dusty's suggestion, however this PR should be moved to the upstream source for this template: https://github.com/coreos/repo-templates/blob/main/fcos/release-checklist.md.
|
Good catch @marmijo |