Skip to content

Conversation

@tlbueno
Copy link
Member

@tlbueno tlbueno commented Oct 1, 2025

  • Update the graph urls to use oci
  • Update previous version verification to remove the parent commit

@tlbueno tlbueno self-assigned this Oct 1, 2025
yasminvalim
yasminvalim previously approved these changes Oct 1, 2025
Copy link

@yasminvalim yasminvalim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@jbtrystram
Copy link
Member

jbtrystram commented Oct 1, 2025

I think we should change the graph tool to query the OCI graph by default rather than changing all the urls here

jbtrystram added a commit to jbtrystram/fedora-coreos-browser that referenced this pull request Oct 1, 2025
Now that we are defaulted to OCI updates and are no longer shipping
OSTree commits to the repo, let's show the OCI graph by default.

Prompted by coreos/fedora-coreos-streams#1137
@tlbueno tlbueno force-pushed the tb_fix_release_template branch 2 times, most recently from 4920111 to c16bab0 Compare October 1, 2025 16:20
@tlbueno
Copy link
Member Author

tlbueno commented Oct 1, 2025

I think we should change the graph tool to query the OCI graph by default rather than changing all the urls here

Yes, that is better. I just updated this PR to change only the parent version verification.

@tlbueno tlbueno requested a review from yasminvalim October 1, 2025 16:21
dustymabe pushed a commit to coreos/fedora-coreos-browser that referenced this pull request Oct 1, 2025
Now that we are defaulted to OCI updates and are no longer shipping
OSTree commits to the repo, let's show the OCI graph by default.

Prompted by coreos/fedora-coreos-streams#1137
- Update previous version verification to remove the parent commit

Signed-off-by: Tiago Bueno <[email protected]>
@tlbueno tlbueno force-pushed the tb_fix_release_template branch from c16bab0 to 42e8531 Compare October 2, 2025 17:02
@tlbueno tlbueno requested a review from dustymabe October 2, 2025 17:03

Using the [the build browser for the `next` stream](https://builds.coreos.fedoraproject.org/browser?stream=next):

- Verify that the parent commit and version match the previous `next` release (in the future, we'll want to integrate this check in the release job)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/match/matches

before it was two things that need to match

now it's just one thing and I think that means it should be matches, but I'm no grammar expert, for sure.

Copy link
Member

@dustymabe dustymabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion. LGTM

Copy link
Member

@marmijo marmijo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than Dusty's suggestion, however this PR should be moved to the upstream source for this template: https://github.com/coreos/repo-templates/blob/main/fcos/release-checklist.md.

@dustymabe
Copy link
Member

Good catch @marmijo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants