Load Requirement Ranking for Frontend #876
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
[diff-counting] Significant lines: 112. |
Contributor
|
Visit the preview URL for this PR (updated for commit 938f6bd): https://cornelldti-courseplan-dev--pr876-pablo-load-fulfillme-gucxujaa.web.app (expires Wed, 03 Jan 2024 01:35:32 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 6d4e0437c4559ed895272bbd63991394f1e0e933 |
zachary-kent
requested changes
Dec 4, 2023
Collaborator
zachary-kent
left a comment
zachary-kent
left a comment
There was a problem hiding this comment.
I think we should just store the recommendations for a requirement already properly ranked in the Firestore so we don't have to do that computation on the frontend.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR is the last in the series to implement course recommendations based on course popularity #866 computed and stored the data in firebase, giving course rankings of a given requirement's slot. #873 implemented frontend changes for displaying the course recommendations. This PR takes the the data computed and stored from firebase, stores it into the Vuex store, and gives the information to the frontend so the frontend can display course popularities. It should be noted that #873 should be backwards compatible and so this PR can be merged before or after #867.
Test Plan