Change np.in1d into np.isin as np.in1d will be deprecated with new versions of NumPy#40
Merged
rossant merged 1 commit intocortex-lab:masterfrom Dec 2, 2023
Merged
Conversation
|
Hey @zm711 do you know who best to ping for a review? |
Contributor
Author
|
@JoeZiminski , I don't. For the main phy repo @rossant has responded in the past, but I don't know who is managing phylib currently. |
Contributor
|
Thanks for the PR! LGTM, merging. cc @oliche @mayofaulkner |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is just to try to future-proof phylib since within a few releases this could lead to a hard error.
https://numpy.org/devdocs/release/2.0.0-notes.html
Then if this is approved it would either need a new pypi release or switching the build instruction for phy.