Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (5)
💤 Files with no reviewable changes (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughRemoved Lens (chainId 232) across the repo: CI/workflow matrices and jobs, npm scripts, network mappings and RPCs, auxiliary lists and public JSON assets/images, issue-template network options; added chain validation script and TypeScript/typecheck scripts; bumped Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
alfetopito
left a comment
There was a problem hiding this comment.
There are also Lens tokens in the default token list https://github.com/cowprotocol/token-lists/blob/main/src/public/CowSwap.json#L1785-L1800
Removal requires a major version bump
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@package.json`:
- Line 51: Remove all references to the removed enum member
SupportedChainId.LENS introduced by `@cowprotocol/cow-sdk` v8: locate the entries
keyed by SupportedChainId.LENS in COINGECKO_CHAINS, DISPLAY_CHAIN_NAMES and
DEFAULT_RPC_URLS and delete those key/value pairs so the maps no longer
reference LENS; ensure no other code paths assume that key (e.g., any lookup or
iteration) and run a build to confirm compilation succeeds.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: a91d1a61-244b-463d-811d-36229a4ded97
⛔ Files ignored due to path filters (4)
src/public/images/232/0x6bdc36e20d267ff0dd6097799f82e78907105e2f/logo.pngis excluded by!**/*.pngsrc/public/images/232/0xe5ecd226b3032910ceaa43ba92ee8232f8237553/logo.pngis excluded by!**/*.pngsrc/public/images/232/0xeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee/logo.pngis excluded by!**/*.pngyarn.lockis excluded by!**/yarn.lock,!**/*.lock
📒 Files selected for processing (9)
.github/workflows/updatePermitInfo.ymlREADME.mdpackage.jsonscripts/processRequest.mjssrc/public/CoinGecko.232.jsonsrc/public/PermitInfo.232.jsonsrc/public/Uniswap.232.jsonsrc/public/images/232/0x6bdc36e20d267ff0dd6097799f82e78907105e2f/info.jsonsrc/public/images/232/0xe5ecd226b3032910ceaa43ba92ee8232f8237553/info.json
💤 Files with no reviewable changes (7)
- README.md
- src/public/images/232/0xe5ecd226b3032910ceaa43ba92ee8232f8237553/info.json
- src/public/CoinGecko.232.json
- scripts/processRequest.mjs
- src/public/images/232/0x6bdc36e20d267ff0dd6097799f82e78907105e2f/info.json
- src/public/Uniswap.232.json
- src/public/PermitInfo.232.json
Yep, forgot a couple of places. I've now removed Lens from everywhere, including the GitHub forms. I also see it will not be removed from |
| run: yarn validate:chains | ||
|
|
||
| - name: TypeScript check | ||
| run: yarn typecheck |
There was a problem hiding this comment.
Also added this here.
| } | ||
|
|
||
| function main(): void { | ||
| const supportedChainIds = new Set(ALL_CHAINS_IDS) |
There was a problem hiding this comment.
Keep in mind that ALL_CHAINS_IDS contains also chains that are not supported, such as Optimism, Bitcoin and Solana
Is that intentional?
Summary by CodeRabbit
Chores
Documentation
CI / Validation