Skip to content

chore(chains)!: Remove Lens network support#1367

Open
Danziger wants to merge 8 commits intomainfrom
feat/cow-243-remove-lens
Open

chore(chains)!: Remove Lens network support#1367
Danziger wants to merge 8 commits intomainfrom
feat/cow-243-remove-lens

Conversation

@Danziger
Copy link
Contributor

@Danziger Danziger commented Mar 11, 2026

Summary by CodeRabbit

  • Chores

    • Removed support for the Lens blockchain (chain ID 232) across workflows, configs, assets, and maintenance scripts.
    • Updated @cowprotocol/cow-sdk to v8.0.0.
  • Documentation

    • Removed Lens entries from generated token-list documentation and related public data.
  • CI / Validation

    • Split validation into schema and chains, added a TypeScript check, and added a new chain-validation script.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 11, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: fa5fd66b-8f41-458f-9667-1e42c86eb38f

📥 Commits

Reviewing files that changed from the base of the PR and between 0e689c9 and 8effcd6.

📒 Files selected for processing (5)
  • .github/workflows/ci.yml
  • .github/workflows/executeAction.yml
  • package.json
  • src/public/CowSwap.json
  • src/scripts/validateSupportedChains.ts
💤 Files with no reviewable changes (1)
  • src/public/CowSwap.json
🚧 Files skipped from review as they are similar to previous changes (1)
  • package.json

📝 Walkthrough

Walkthrough

Removed Lens (chainId 232) across the repo: CI/workflow matrices and jobs, npm scripts, network mappings and RPCs, auxiliary lists and public JSON assets/images, issue-template network options; added chain validation script and TypeScript/typecheck scripts; bumped @cowprotocol/cow-sdk to 8.0.0.

Changes

Cohort / File(s) Summary
CI/CD workflows
.github/workflows/updatePermitInfo.yml, .github/workflows/ci.yml, .github/workflows/executeAction.yml
Removed chainId 232 from workflow matrix; split/renamed validation steps into validate:schema and validate:chains and added typecheck step; job/step renames.
Package scripts & deps
package.json
Renamed validatevalidate:schema; added validate:chains and typecheck; removed fetchPermitInfo:lens; bumped @cowprotocol/cow-sdk 7.3.1 → 8.0.0.
Network config & RPCs
scripts/processRequest.mjs, src/permitInfo/const.ts
Removed LENS entry from NETWORK_CONFIG and deleted its RPC URL in DEFAULT_RPC_URLS.
Auxiliary scripts & utils
src/scripts/auxLists/utils.ts, src/scripts/validateSupportedChains.ts, README.md
Removed LENS mappings from COINGECKO_CHAINS and DISPLAY_CHAIN_NAMES; added validateSupportedChains.ts to enforce allowed chain IDs for src/public/CowSwap.json; removed Lens mentions from README token-list docs.
Public token lists & datasets (removed)
src/public/CoinGecko.232.json, src/public/Uniswap.232.json, src/public/PermitInfo.232.json, src/public/CowSwap.json
Deleted Lens-specific JSON manifests and removed two chainId 232 token entries from CowSwap.json.
Image metadata (deleted)
src/public/images/232/0x6bdc36e20d267ff0dd6097799f82e78907105e2f/info.json, src/public/images/232/0xe5ecd226b3032910ceaa43ba92ee8232f8237553/info.json
Removed Lens token image/info JSON files.
Issue templates
.github/ISSUE_TEMPLATE/1-addTokenForm.yml, .github/ISSUE_TEMPLATE/2-addImageForm.yml, .github/ISSUE_TEMPLATE/3-removeTokenForm.yml
Removed LENS option from network dropdowns in Add Token, Add Image, and Remove Token templates.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

🐰 I nibbled out chain two-three-two,
Pages and scripts now lean and new,
Removed a branch, trimmed token art,
One small hop, a tidy cart,
Happy thumps — a rabbit's queue.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: removing support for the Lens network across the repository.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/cow-243-remove-lens
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@socket-security
Copy link

socket-security bot commented Mar 11, 2026

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updated@​cowprotocol/​cow-sdk@​7.3.1 ⏵ 8.0.079 +110010099100

View full report

@Danziger Danziger requested a review from a team March 11, 2026 16:44
Copy link
Collaborator

@alfetopito alfetopito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are also Lens tokens in the default token list https://github.com/cowprotocol/token-lists/blob/main/src/public/CowSwap.json#L1785-L1800

Removal requires a major version bump

@alfetopito
Copy link
Collaborator

@coderabbitai review

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 11, 2026

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@package.json`:
- Line 51: Remove all references to the removed enum member
SupportedChainId.LENS introduced by `@cowprotocol/cow-sdk` v8: locate the entries
keyed by SupportedChainId.LENS in COINGECKO_CHAINS, DISPLAY_CHAIN_NAMES and
DEFAULT_RPC_URLS and delete those key/value pairs so the maps no longer
reference LENS; ensure no other code paths assume that key (e.g., any lookup or
iteration) and run a build to confirm compilation succeeds.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: a91d1a61-244b-463d-811d-36229a4ded97

📥 Commits

Reviewing files that changed from the base of the PR and between d18cd7a and 378e2e7.

⛔ Files ignored due to path filters (4)
  • src/public/images/232/0x6bdc36e20d267ff0dd6097799f82e78907105e2f/logo.png is excluded by !**/*.png
  • src/public/images/232/0xe5ecd226b3032910ceaa43ba92ee8232f8237553/logo.png is excluded by !**/*.png
  • src/public/images/232/0xeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee/logo.png is excluded by !**/*.png
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock
📒 Files selected for processing (9)
  • .github/workflows/updatePermitInfo.yml
  • README.md
  • package.json
  • scripts/processRequest.mjs
  • src/public/CoinGecko.232.json
  • src/public/PermitInfo.232.json
  • src/public/Uniswap.232.json
  • src/public/images/232/0x6bdc36e20d267ff0dd6097799f82e78907105e2f/info.json
  • src/public/images/232/0xe5ecd226b3032910ceaa43ba92ee8232f8237553/info.json
💤 Files with no reviewable changes (7)
  • README.md
  • src/public/images/232/0xe5ecd226b3032910ceaa43ba92ee8232f8237553/info.json
  • src/public/CoinGecko.232.json
  • scripts/processRequest.mjs
  • src/public/images/232/0x6bdc36e20d267ff0dd6097799f82e78907105e2f/info.json
  • src/public/Uniswap.232.json
  • src/public/PermitInfo.232.json

@Danziger Danziger changed the title chore(chains)!: remove Lens network support chore(chains)!: Remove Lens network support Mar 11, 2026
@Danziger
Copy link
Contributor Author

There are also Lens tokens in the default token list https://github.com/cowprotocol/token-lists/blob/main/src/public/CowSwap.json#L1785-L1800

Removal requires a major version bump

Yep, forgot a couple of places. I've now removed Lens from everywhere, including the GitHub forms.

I also see it will not be removed from CowSwap.json automatically. I've done it manually and I'll now push a script to validate we don't leave entries behind.

run: yarn validate:chains

- name: TypeScript check
run: yarn typecheck
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also added this here.

Copy link
Collaborator

@alfetopito alfetopito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment

}

function main(): void {
const supportedChainIds = new Set(ALL_CHAINS_IDS)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep in mind that ALL_CHAINS_IDS contains also chains that are not supported, such as Optimism, Bitcoin and Solana

https://github.com/cowprotocol/cow-sdk/blob/5f7ecfba74abc721b80c5fe6f4997f9518c40788/packages/config/src/chains/const/chainIds.ts#L63-L90

Is that intentional?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants