fix: glob now falls back to real filesystem for unmocked paths (#158)#197
Open
atoomic wants to merge 1 commit intocpanel:masterfrom
Open
fix: glob now falls back to real filesystem for unmocked paths (#158)#197atoomic wants to merge 1 commit intocpanel:masterfrom
atoomic wants to merge 1 commit intocpanel:masterfrom
Conversation
…l#158) The __glob override only searched %files_being_mocked via Text::Glob, never falling back to CORE::glob for real filesystem results. This caused glob() to return empty results for real files on disk when Test::MockFile was loaded (even in nostrict mode with nothing mocked). Now __glob merges real CORE::glob results with mocked file matches, skipping any paths that are actively mocked (mock takes precedence). Results are sorted to maintain glob's alphabetical order contract. Closes cpanel#158 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The __glob override only searched %files_being_mocked via Text::Glob, never falling back to CORE::glob for real filesystem results. This caused glob() to return empty results for real files on disk when Test::MockFile was loaded (even in nostrict mode with nothing mocked).
Now __glob merges real CORE::glob results with mocked file matches, skipping any paths that are actively mocked (mock takes precedence). Results are sorted to maintain glob's alphabetical order contract.
Closes #158