Move installer to inertia #18064
Draft
Move installer to inertia #18064
+1,717
−180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
riasvdv
approved these changes
Nov 14, 2025
Comment on lines
+87
to
+89
| $this->loadViewsFrom("{$this->root}/resources/views", 'c'); | ||
|
|
||
| Vite::useHotFile("{$this->root}/resources/hot"); |
Contributor
There was a problem hiding this comment.
We already have this one as well https://github.com/craftcms/cms/blob/6.x/src/Twig/TwigServiceProvider.php#L15
I'd probably add a ViewServiceProvider and merge some of the things into that.
Comment on lines
+44
to
+48
|
|
||
| public static function cpLocale(): string | ||
| { | ||
| return config('app.locale', 'en-US'); | ||
| } |
Contributor
There was a problem hiding this comment.
There's app()->getLocale() you can use globally.
Ran into performance issues due to the number of items in the locales list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Biting off a bit less than #18005 — moves the installer to Inertia. Still a lot of plumbing included in this one, but an easier first step.