This repository was archived by the owner on Apr 21, 2021. It is now read-only.
Parse env vars for username and API key#4
Open
brianjhanson wants to merge 2 commits intocraftcms:masterfrom
Open
Parse env vars for username and API key#4brianjhanson wants to merge 2 commits intocraftcms:masterfrom
brianjhanson wants to merge 2 commits intocraftcms:masterfrom
Conversation
These ended up messing with the JS on the volume settings page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I know this plugin is pretty much deprecated, but I'm having to work with it for a bit before transitioning off to something else. In the mean time, I didn't want to expose our API keys to the project config file.
This PR adds the ability to save the username and API Key as environment variables or aliases. Also updates those fields to be autosuggest fields to make retrieving them a bit easier.