Add DateTime detection for OpenAPI date-time format#34
Open
tomasvanrijsse wants to merge 1 commit intocrescat-io:masterfrom
Open
Add DateTime detection for OpenAPI date-time format#34tomasvanrijsse wants to merge 1 commit intocrescat-io:masterfrom
tomasvanrijsse wants to merge 1 commit intocrescat-io:masterfrom
Conversation
Detect and map OpenAPI string fields with format: "date-time" to \Carbon\Carbon type hints in generated DTOs. This provides better type safety and IDE autocomplete for datetime properties. Changes: - Modified DtoGenerator::mapType() to check for date-time format - String fields with format: "date-time" now generate \Carbon\Carbon type - Nullable datetime fields generate ?\Carbon\Carbon This implementation relies only on the OpenAPI specification (format field) rather than property naming conventions. Related to Phase 1, PR crescat-io#2 of generator improvements. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Detect and map OpenAPI string fields with format: "date-time" to \Carbon\Carbon type hints in generated DTOs. This provides better type safety and IDE autocomplete for datetime properties.
Changes:
This implementation relies only on the OpenAPI specification (format field) rather than property naming conventions.
Related to Phase 1, PR #2 of generator improvements.