julia/MOLE.jl: Add addScalarBC, relative BCs tests and elliptic1DaddScalarBC example #300
Open
valeriabarra wants to merge 1 commit intomainfrom
Open
julia/MOLE.jl: Add addScalarBC, relative BCs tests and elliptic1DaddScalarBC example #300valeriabarra wants to merge 1 commit intomainfrom
valeriabarra wants to merge 1 commit intomainfrom
Conversation
…dScalarBC! julia/MOLE.jl: add addScalarBC tests and elliptic1DaddScalarBC.jl example
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
This PR adds a new set of Boundary Conditions in Julia. Specifically, it adds:
AbstractScalarBCabstract type (so that we can generalize to multiple dimensions later)ScalarBC1Dconcrete type and convenience constructoraddScalarBC!functions to apply the scalar type BCselliptic1DaddScalarBC.mexample aselliptic1DaddScalarBC.jlRelated Issues & Documents
addScalarBC1DBoundary Condition and add an example that shows its usage (elliptic1DaddScalarBC) #299QA Instructions, Screenshots, Recordings
Added/updated tests?
We encourage you to test all code included with MOLE, including examples.
have not been included
Read Contributing Guide and Code of Conduct