Skip to content

[-] fix source config update handling #1106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
0xgouda merged 5 commits into from
Jan 7, 2026
Merged

[-] fix source config update handling #1106

0xgouda merged 5 commits into from
Jan 7, 2026
+533 −22

Conversation

@0xgouda
Copy link
Collaborator

@0xgouda 0xgouda commented Jan 2, 2026 •
edited
Loading

  • Ensure that all gatherers have up-to-date configs (e.g., connections, intervals, etc.) from their source by restarting all gatherers under a specific source on config update.

Closes: #1085
Closes: #1091
Closes: #1084
Closes: #1113

@0xgouda 0xgouda mentioned this pull request Jan 2, 2026
Closed
@0xgouda 0xgouda force-pushed the fix-src-update-logic branch from df8b6f5 to 4f5b0c6 Compare January 2, 2026 06:09
@0xgouda 0xgouda requested a review from pashagolub January 2, 2026 06:11
@coveralls
Copy link

coveralls commented Jan 2, 2026 •
edited
Loading

Pull Request Test Coverage Report for Build 20782379988

Details

  • 15 of 16 (93.75%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.7%) to 75.296%
Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/reaper/reaper.go 11 12 91.67%
Totals Coverage Status
Change from base Build 20781563395: 0.7%
Covered Lines: 4011
Relevant Lines: 5327
💛 - Coveralls

@0xgouda 0xgouda marked this pull request as draft January 4, 2026 14:17
@0xgouda 0xgouda marked this pull request as ready for review January 5, 2026 06:12
@0xgouda 0xgouda marked this pull request as draft January 5, 2026 08:49
@0xgouda 0xgouda force-pushed the fix-src-update-logic branch from 9c26e03 to a5b7292 Compare January 5, 2026 13:15
@pashagolub
Copy link
Collaborator

pashagolub commented Jan 5, 2026

We should consolidate the stopping functionality into one place and just call the routine whenever we think it's appropriate. What do you think @0xgouda?

pashagolub
pashagolub reviewed Jan 5, 2026
View reviewed changes
@0xgouda
Copy link
Collaborator Author

0xgouda commented Jan 5, 2026

We should consolidate the stopping functionality into one place and just call the routine whenever we think it's appropriate. What do you think @0xgouda?

I marked this as a draft because I was working on it; all will be using ShutdownOldWorkers(). Please re-check. I just pushed the changes.

@pashagolub
Copy link
Collaborator

pashagolub commented Jan 5, 2026

Oh, I see. I was confused by "review equested"

@pashagolub pashagolub self-assigned this Jan 5, 2026
@pashagolub pashagolub added bug Something isn't working sources What sources and in what way to monitor labels Jan 5, 2026
@0xgouda 0xgouda marked this pull request as ready for review January 6, 2026 09:12
@0xgouda 0xgouda force-pushed the fix-src-update-logic branch from 32e67d5 to f8deca5 Compare January 6, 2026 09:12
@0xgouda 0xgouda requested a review from pashagolub January 6, 2026 09:18
@pashagolub
Copy link
Collaborator

pashagolub commented Jan 7, 2026

Looks good. We might later improve cleaning routines.

pashagolub
pashagolub approved these changes Jan 7, 2026
View reviewed changes
@0xgouda 0xgouda merged commit e8de600 into master Jan 7, 2026
9 checks passed
@0xgouda 0xgouda deleted the fix-src-update-logic branch January 7, 2026 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pashagolub pashagolub pashagolub approved these changes

Assignees

@pashagolub pashagolub

Labels

bug Something isn't working sources What sources and in what way to monitor

Projects

None yet

Milestone

No milestone

4 participants

@0xgouda @coveralls @pashagolub