fix: add fallback to CreationTimestamp in getJobCreationTimestamp #204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR adds a fallback mechanism to the getJobCreationTimestamp function to use the Job's CreationTimestamp when the batch.kubernetes.io/cronjob-scheduled-timestamp annotation is not present. This change improves robustness by allowing the function to handle Jobs that are not created by CronJobs or lack the expected annotation.
Key Changes:
- Added fallback logic to return
job.CreationTimestamp.Timewhen the annotation is missing - Updated function documentation to reflect the new fallback behavior
- Removed the error path that previously returned an error for missing annotations
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Kyori Sakao <[email protected]>
Signed-off-by: Kyori Sakao <[email protected]>
molpako
force-pushed
the
fix-createfinbackup
branch
from
8f72830 to
f6bc377
Compare
Copilot finished reviewing on behalf of
molpako
December 5, 2025 08:25
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
satoru-takeuchi
approved these changes
Dec 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.