Refactor GuiHelpOverlay and keybind help text population#2688
Open
oznogon wants to merge 1 commit intodaid:masterfrom
Open
Refactor GuiHelpOverlay and keybind help text population#2688oznogon wants to merge 1 commit intodaid:masterfrom
oznogon wants to merge 1 commit intodaid:masterfrom
Conversation
- Use layout parameters in the GuiHelpOverlay main panel. - Increase the panel width to accommodate long bind labels. - Add functions to set GuiHelpOverlay title, contents, and footer. Add a specialized GuiHotkeyHelpOverlay subclass and move all redundant help overlay text population logic from across crew and accessory screens into it. - Move the hint to help players find the hotkeys rebinding menu from the bottom of hotkey contents' scrolltext to a standalone footer label, and correct its reference to the Options menu instead of settings. - Color bindings slightly to distinguish them from labels. - Rename GuiHotkeyHelpOverlays from "Keyboard Shortcuts" to "Controls" since this also already includes game controller and joystick bindings. - List unbound controls below the list of bound controls, and fade them to distinguish them from bound controls.
oznogon
force-pushed
the
refactor-help-overlay
branch
from
936a3b9 to
6bd9180
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a specialized GuiHotkeyHelpOverlay subclass and move all
redundant help overlay text population logic from across crew and
accessory screens into it.
from the bottom of hotkey contents' scrolltext to a standalone
footer label, and correct its reference to the Options menu
instead of settings.
"Controls" since this also already includes game controller and
joystick bindings.
fade them to distinguish them from bound controls.
This stacks on #2687 since it applies keybinding changes to voice chat to hide its keybinds when disabled. These changes can be backed out if #2687 blocks this.
Before:
After: