Merged
Conversation
Apply consistent visibility and update logic patterns across propulsion (impulse, warp, jump) and combat maneuver control wrappers. This prevents inconsistent UI behaviors when adding, removing, and changing their related components at runtime. Also align header guards on use of #pragma once, and remove unnecessary warp_controls and jump_controls pointers from Helms now that visibility logic is consistently handled in the wrapper components.
Add two new helm keybindings: - helms_warp_max: Request maximum warp level, parallel to max impulse and max jump keybinds. Accommodates warp drives with max_level > 4. - helms_set_warp: Set warp request via joystick axis with simulated detents at each warp level.
Remove outdated documentation suggesting warp controls are limited to factor 4.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#pragma once.HELMS_WARP_MAXkeybind to support WarpDrive components with a max_level > 4.HELMS_SET_WARPaxis bind to support setting warp factor by throttle or joystick. This functions similarly to the jump drive axis controls, where the minimum axis value (-1) represents warp 0 and the maximum value (+1) represents warp max_level. This also simulates detents at each integer warp factor via rounding of the axis value.commandWarp()docstring that incorrectly suggests that warp factors have a hard maximum limit of 4.