Merged
Conversation
a3015cd to
e95e2f0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If neither side wins in Clash in Shangri-La, it attempts to declare victory for
Independents, an invalid faction name (should beIndependent). Fix this invalid faction name.This changes the victory screen behavior for this outcome. Before, the game pauses with no victory message. After, the game pauses with a victory message for the Independent faction.
This behavior exposes another issue: functions used to find factions do not log when the passed faction name is invalid. Add warning logging when an invalid faction name is passed to
Faction::find(), and error logging when an invalid faction name is passed tovictory()Example:
results in no functional change in behavior, but adds logging to raise the issue: