Open
Conversation
- Detect ExplosionEffect and ElectricExplosionEffect components.
- Replace color, mesh, and radar trace image checks with component
property checks.
- Asteroids are distinguished by Spin and AvoidObject component
presence instead of mesh path substring check for Astroid
- Visual Asteroids are distinguished by Spin and lack of
AvoidObject
- BlackHoles and WormHoles are distinguished by Gravity component
damage and wormhole_target properties, instead of by
BillboardRender texture
- SupplyDrops are distinguished by containing Pickup component
give_* properties with > 0 values, instead of by radar trace
being blip.png and radar_trace.color_by_faction being true
- Missiles and Mines use MissileFlight, MissileHoming, and
ExplodeOnTimeout instead of radar_trace.icon and
radar_trace.color
- Reorganize if/elseif structure.
oznogon
force-pushed
the
expand-isobjecttype
branch
from
0881d9f to
1239da6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacks on #2732.
ExplosionEffectandElectricExplosionEffectcomponents.property checks.
SpinandAvoidObjectcomponentpresence instead of mesh path substring check for
AstroidSpinand lack ofAvoidObjectBlackHolesandWormHolesare distinguished byGravitycomponentdamageandwormhole_targetproperties, instead of byBillboardRendertexturevalueSupplyDropsare distinguished by containingPickupcomponentgive_*properties with > 0 values, instead of byradar_trace.iconbeing
blip.pngandradar_trace.color_by_factionbeingtrueMissileFlight,MissileHoming, andExplodeOnTimeout(exposed by Expose missile-related components #2732) instead ofradar_trace.iconand
radar_trace.color