Conversation
This makes the memory order explicit w.r.t. Exchange and Retrieve.
Retrieve uses sequentially consistent memory order, so calling it on every loop iteration can introduce extra overhead from memory barriers. It's more efficient to check for null first (using relaxed memory order) and then only call Retrieve if it looks like there's actually a free transaction there to take.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Retrieveuses sequentially consistent memory order, so calling it on every loop iteration can introduce extra overhead from memory barriers. It's more efficient to check for null first (using relaxed memory order) and then only callRetrieveif it looks like there's actually a free transaction there to take.Check_Is_Nullis also changed to use__atomic_load_nto make it explicit that the load uses relaxed memory order.