Darkens the actionbar in dark/night themes #777
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
I honestly don't think I like this change. For the actionbar it seems mostly fine. Now the colored header text is muted and hard to read whereas the point of having it be a separate color was to make it stand out. |
Contributor
Author
|
Which text do you mean? The "Select Folder" label text? I can try to figure out how to keep those brighter.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I darkened the colors to 66% of the light colors, except for darkPrimaryDark which is 50%.
Because the Black theme inherits from Dark, this change also applies in that theme. Holo has its own settings.