Remove several dependencies#11
Open
RandomInsano wants to merge 1 commit intodanii:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems that the
visibilitycrate was to just make certain functions public to test. I figured the easier thing to do would be to change the function visibility to just be for the crate and this should make sure they can't be used by other crates (the CLI included) effectively meaning they should by dropped for being unused.The only real reason I did this is that I want to use Hematita on Windows 7 (yes, it's over 13 years old) and I had thought that some of my compiler errors being thrown by some dependencies could be fixed by removing them. Sadly no! But hopefully things compile a lot faster. That's a win too.