docs: self-merge PRs by default#389
Conversation
Reverse the prior "require independent review" policy. Everything still goes through a PR, but a PR is merged once its required checks pass -- self-merging your own PR is now the norm. The only PRs left unmerged are ones the user has flagged as needing someone else's approval first. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5f1b9caeba
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| - Before creating a new worktree, ensure the repo-supported test suite is green on the intended base. If the suite is not green, pause before creating the worktree and notify the user with the failing command and failure summary. | ||
| - New behavior changes start on a worktree branch from `origin/main` and are submitted as PRs to `origin/main`; local `dev` only consumes PR heads. | ||
| - Everything goes through a PR — never push behavior changes directly to `origin/main`. | ||
| - Merge PRs once their required checks pass; self-merging your own PRs is the norm. The only exception is a PR the user has said needs someone else to approve it first — leave those unmerged. |
There was a problem hiding this comment.
This new self-merge rule conflicts with the repo's dedicated branch model documentation: docs/development/branch-model.md:33 still says to wait for independent review before merging to origin/main. Agents following that workflow document will continue leaving PRs unmerged even after required checks pass, so the policy update should include that page as well.
Useful? React with 👍 / 👎.
2 participants
Updates the documented repo rules to match the agreed policy: everything still goes through a PR, but PRs are merged by default once required checks pass — self-merging your own PR is now the norm. The only PRs left unmerged are ones the user flags as needing someone else's approval first.
Changes (
AGENTS.md)origin/main), and that PRs are self-merged once required checks pass — except when the user says a PR needs outside approval first.origin/mainchanges still require independent review" with the self-merge-is-the-norm policy.No code or behavior changes. The GitHub rulesets already enforce this (PR required,
required_approving_review_count: 0), so no ruleset change was needed.🤖 Generated with Claude Code