Skip to content

fix: skip system context for coding session auto-names#393

Merged
danshapiro merged 1 commit into
mainfrom
fix/codex-combined-prompt-title
Jun 5, 2026
Merged

fix: skip system context for coding session auto-names#393
danshapiro merged 1 commit into
mainfrom
fix/codex-combined-prompt-title

Conversation

@danshapiro
Copy link
Copy Markdown
Owner

Summary

  • root cause: Codex/Claude parsers stored system-context user records like AGENTS.md as firstUserMessage before applying the system-context filter
  • fix: add shared user-authored text extraction and use it for provider parsing plus lightweight indexer titles
  • tests: cover AGENTS-only records, IDE request extraction, and parser firstUserMessage behavior

Verification

  • npm run test:vitest -- test/unit/server/coding-cli/utils.test.ts test/unit/server/coding-cli/codex-provider.test.ts test/unit/server/coding-cli/claude-provider.test.ts test/unit/server/coding-cli/session-indexer.test.ts --run
  • npm run check

@danshapiro danshapiro merged commit d1704fd into main Jun 5, 2026
1 check passed
@danshapiro danshapiro deleted the fix/codex-combined-prompt-title branch June 5, 2026 02:25
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: cacd42fd88

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +390 to +391
const ideRequest = extractFromIdeContext(trimmed)
if (ideRequest) return ideRequest
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Preserve full IDE request text for firstUserMessage

When an IDE-context record contains a multi-line ## My request for Codex: section, this returns extractFromIdeContext(...), which only returns the first non-empty line of that section. The same userAuthoredText is now used to populate firstUserMessage in both Claude and Codex providers, so sessions with requests like Implement X\n- handle A\n- handle B lose everything after the first line; that truncated value is later used for AI title generation, session search, and first-chat exclusion filters. Title extraction can still use the first line, but the canonical first user message should keep the full request body.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants