Deprecate the export of package:matcher APIs#1978
Draft
Conversation
Add a `replacedBy` transform for every member of the `package:matcher/expect.dart` library which changes only the URI.
PR Health |
Member
Author
|
@keertip @bwilkerson - Is there a way to handle a class moved to a different import? This seems to be working well to use
|
Member
|
It appears that we don't currently support using I know that at one point we discussed adding a |
Member
Author
|
I filed dart-lang/sdk#57057 to track. Either solution sounds great. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests should import the matching framework, either
package:matcher/expect.dart, orpackage:checks/checks.dart, or somethird party alternative.
package:matcher/expect.darttoreplace the member with the
package:test/test.dartURI.exportdeprecated`.librarydirective so the deprecation annotation isunambiguously applied to the export and not the entire library.
matcherdependency andimport. Manually sort dependencies to satisfy a separate lint.