TST Fixes random seed for flaky test_keras#800
Open
thomasjpfan wants to merge 2 commits intodask:mainfrom
Open
TST Fixes random seed for flaky test_keras#800thomasjpfan wants to merge 2 commits intodask:mainfrom
thomasjpfan wants to merge 2 commits intodask:mainfrom
Conversation
stsievert
reviewed
Feb 27, 2021
Member
stsievert
left a comment
stsievert
left a comment
There was a problem hiding this comment.
Yeah, random_state is producing the errors. I'm not seeing why else the test would be non-deterministic.
Co-authored-by: Scott Sievert <stsievert@users.noreply.github.com>
Member
|
Hm.... looks like the error has to do with timeout on windows. I'm not seeing how that's induced by this PR. |
Contributor
Author
stsievert
approved these changes
Mar 1, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #794
I suspect the failing test on
mainis due to sampling of the parameter space that may lead to scores that are constant.CC @stsievert