Skip to content

[PLUGIN-1958] Added error message reason in case of failures while get Schema #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vikasrathee-cs merged 1 commit into from
Apr 28, 2026
Merged

[PLUGIN-1958] Added error message reason in case of failures while get Schema #82

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/main/java/io/cdap/plugin/google/sheets/source/GoogleSheetsSourceConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -596,8 +596,8 @@ private void getAndValidateSheetSchema(FailureCollector collector, GoogleSheetsS
}
} catch (IOException e) {
collector.addFailure(
String.format("Failed to prepare headers, spreadsheet id: '%s', sheet title: '%s'.",
currentSpreadsheetId, currentSheetTitle), null);
String.format("Failed to prepare headers, spreadsheet id: '%s', sheet title: '%s' due to reason: '%s'.",
currentSpreadsheetId, currentSheetTitle, e.getMessage()), null);
}
}
}
Expand Down
33 changes: 33 additions & 0 deletions src/test/java/io/cdap/plugin/google/sheets/source/GoogleSheetsSourceConfigTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@

package io.cdap.plugin.google.sheets.source;

import com.google.api.services.drive.model.File;
import com.google.api.services.sheets.v4.model.CellData;
import com.google.api.services.sheets.v4.model.ExtendedValue;
import com.google.api.services.sheets.v4.model.GridRange;
Expand All @@ -27,7 +28,9 @@
import io.cdap.plugin.google.sheets.source.utils.MetadataKeyValueAddress;
import org.junit.Assert;
import org.junit.Test;
import org.mockito.Mockito;

import java.io.IOException;
import java.lang.reflect.Field;
import java.lang.reflect.InvocationTargetException;
import java.lang.reflect.Method;
Expand Down Expand Up @@ -471,4 +474,34 @@ public void testProcessColumnsInvalidTitlesOldSchema()
Assert.assertEquals("d", subColumns.get(1).getHeaderTitle());
Assert.assertTrue(subColumns.get(0).getSubColumns().isEmpty());
}

@Test
public void testGetAndValidateSheetSchemaIOException() throws Exception {
FailureCollector collector = new DefaultFailureCollector("", Collections.EMPTY_MAP);
GoogleSheetsSourceClient mockClient = Mockito.mock(GoogleSheetsSourceClient.class);

List<File> spreadsheetsFiles = new ArrayList<>();
File mockFile = new File();
mockFile.setId("spreadsheetId");
spreadsheetsFiles.add(mockFile);

Mockito.when(mockClient.getSheetsTitles("spreadsheetId")).thenReturn(Arrays.asList("Sheet1"));

Mockito.when(mockClient.getSingleRows(Mockito.anyString(), Mockito.anyString(), Mockito.anySet()))
.thenThrow(new IOException("Mocked IO exception"));

setFieldValue("sheetsToPull", "all");
setFieldValue("columnNamesSelection", "noColumnNames");

Method method = GoogleSheetsSourceConfig.class.getDeclaredMethod("getAndValidateSheetSchema",
FailureCollector.class, GoogleSheetsSourceClient.class, List.class);
method.setAccessible(true);

method.invoke(config, collector, mockClient, spreadsheetsFiles);

Assert.assertEquals(1, collector.getValidationFailures().size());
ValidationFailure failure = collector.getValidationFailures().get(0);
Assert.assertTrue(failure.getMessage().contains("Failed to prepare headers"));
Assert.assertTrue(failure.getMessage().contains("due to reason: 'Mocked IO exception'"));
}
}
Loading