fix(config): Allow using YAML format for global config file#63
Open
gopi-databricks wants to merge 1 commit intomainfrom
Open
fix(config): Allow using YAML format for global config file#63gopi-databricks wants to merge 1 commit intomainfrom
gopi-databricks wants to merge 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #50
Issue:
We hit
JSONDecodeError:if we use YAML format forpipeline_configs/global.yamlThis is because
dlt_pipeline_builder.pyusesutility.get_json_from_file()to load the global config file which supports loading only JSON file.Failed run:
https://e2-demo-field-eng.cloud.databricks.com/pipelines/32f8d914-b5fe-4ed8-ad58-f062897b795d/updates/5d02141c-c61e-43f3-a08d-f3fd7540cf6d?o=1444828305810485
What changes made?
A straighforward fix to use
utility.load_config_file_autowill fix this problem.Tests:
Deployed the change in internal databricks workspace and verified the run is successful
Successful run:
https://e2-demo-field-eng.cloud.databricks.com/pipelines/32f8d914-b5fe-4ed8-ad58-f062897b795d/updates/611c6014-6ce4-4c8f-a768-feeacf929ae1?o=1444828305810485