Automated Integration Test Goldens Update from CI#6098
Conversation
…b54-9d0c-4c13795f46b5)
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request contains automated updates to integration test golden files. The primary purpose of these changes is to standardize the representation of the country 'United States' to its more formal name, 'United States of America,' across various chart configuration and debug information JSON files. These updates ensure that the test outputs align with the desired naming conventions and reflect the latest expected golden states. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
9804dfd
into
migrate-place-info-v2-golden-updates
There was a problem hiding this comment.
Code Review
This pull request automatically updates golden files for integration tests. The majority of changes involve updating the place name from "United States" to "United States of America", which is a consistent and appropriate change. However, I've noticed a couple of instances where floating-point scores in test data have been updated with increased precision. According to the repository's general rules, scores should be rounded to a consistent, lower precision to improve test robustness and reduce noise from minor model variations. I've left specific comments with suggestions to adhere to this rule.
| 0.38534, | ||
| 0.38184, | ||
| 0.3797 | ||
| 0.37971 |
There was a problem hiding this comment.
The precision of this score has been increased from 4 to 5 decimal places. To improve test robustness against minor model output variations, it's recommended to use a consistent, lower precision for floating-point scores in test data.
While this change makes the precision consistent with other values in this list, it increases the precision which can lead to test brittleness. I suggest we round this value to 3 decimal places. For overall consistency, it would be best to apply this rounding to all scores in this list in a follow-up.
| 0.37971 | |
| 0.380 |
References
- Round floating-point scores in test data to a consistent, lower precision. This makes tests more robust against insignificant model output variations and reduces review noise.
| 0.63227, | ||
| 0.63222, | ||
| 0.6305, | ||
| 0.63049, |
There was a problem hiding this comment.
The precision of this score has been increased from 4 to 5 decimal places. To improve test robustness, our general rules recommend using a consistent, lower precision for floating-point scores.
This list of scores already has inconsistent precision. Instead of increasing precision, I suggest we round this value to 3 decimal places. For overall consistency, it would be best to apply this rounding to all scores in this list in a follow-up.
| 0.63049, | |
| 0.630, |
References
- Round floating-point scores in test data to a consistent, lower precision. This makes tests more robust against insignificant model output variations and reduces review noise.
This pull request updates the golden files automatically via Cloud Build. Please review the changes carefully. Cloud Build Log
Edit from @SandeepTuniki: Don't review/approve. I triggered this PR creation manually (through cloudbuild) as part of my work in #6047. I'll club the changes of this PR into #6047.