-
Notifications
You must be signed in to change notification settings - Fork 13
fix: add ENTER key support to db-switch #5444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Copilot
wants to merge
6
commits into
main
Choose a base branch
from
copilot/fix-db-switch-enter-functionality
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 0b08cf4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Co-authored-by: mfranzke <[email protected]>
Co-authored-by: mfranzke <[email protected]>
Co-authored-by: mfranzke <[email protected]>
Copilot
AI
changed the title
[WIP] Fix db-switch not reacting to ENTER key
fix: add ENTER key support to db-switch for ARIA compliance
Nov 12, 2025
Copilot finished work on behalf of
mfranzke
November 12, 2025 14:31
mfranzke
reviewed
Nov 12, 2025
mfranzke
approved these changes
Nov 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
The db-switch component only responded to SPACE key for toggling, not ENTER. Per W3C ARIA switch patterns, both keys should toggle the switch for proper keyboard accessibility.
resolves #5443
Implementation
handleKeyDownmethod toswitch.lite.tsxthat listens for ENTER key and programmatically clicks the inputDBSwitchDefaultStatetype to include the keyboard handler signatureGenerated across all frameworks
The Mitosis build generates correct keyboard handlers for:
(keydown)="handleKeyDown($event)"onKeyDown={(event) => handleKeyDown(event)}@keydown="async (event) => handleKeyDown(event)"onKeyDown={(event) => this.handleKeyDown(event)}Tests
Added Playwright tests verifying:
Types of changes
Further comments
SPACE key behavior is preserved. Only the specific Angular generator was mentioned in the issue, but the fix applies to all framework outputs since it's implemented in the Mitosis source.
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
www-api.ibm.comnode /home/REDACTED/work/core-web/core-web/node_modules/@ibm/telemetry-js/dist/REDACTED-process.js --log=/tmp/ibmtelemetry-20251112T140901257Z-533603.log --config=telemetry.yml(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.
🔭🐙🐈 Test this branch here: https://design-system.deutschebahn.com/core-web/review/copilot/fix-db-switch-enter-functionality