Draft
Conversation
Pwnion
added a commit
to Pwnion/schedule
that referenced
this pull request
Jan 16, 2024
Incorporated changes from SijmenHuizenga's pull request (dbader#438) to add async support.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a draft implementation of supporting async jobs by adding
run_pending_asyncandrun_all_async. These methods would support both normal jobs and coroutine jobs. An usage example:This pr is far from finished. I'm submitting this in such an early stage to continue the conversation about async implementations started in #357. The implementation in this pr is roughly based on the work by @pirroman in pr #357.
I am keen to hear what you think about supporting async in this way.