Fix TypeError in repr when unit is None and interval is 1#651
Open
Fridayai700 wants to merge 1 commit intodbader:masterfrom
Open
Fix TypeError in repr when unit is None and interval is 1#651Fridayai700 wants to merge 1 commit intodbader:masterfrom
Fridayai700 wants to merge 1 commit intodbader:masterfrom
Conversation
Job.__repr__ crashes with `TypeError: 'NoneType' object is not subscriptable` when called on a partially-composed Job with interval=1, because `self.unit[:-1]` is attempted on None. Guard self.unit against None before slicing. Fixes dbader#646. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #646.
repr(schedule.every(1))crashes withTypeError: 'NoneType' object is not subscriptablebecauseself.unit[:-1]is attempted whenself.unitisNone.The fix guards
self.unitagainstNonebefore slicing. WhenunitisNone, it renders as[None](consistent with howjob_funcrenders when unset).Test plan
repr(schedule.every(1))verifies no crashrepr(schedule.every(10))— now renders[None]instead ofNone