Open
Conversation
Collaborator
There was a problem hiding this comment.
Why do you pass these across as strings rather than integers?
properties (which are technically not tags):
{ fileName: '/path/books.jpg',
fileSize: '993738',
mimeType: 'image/jpeg',
pixelHeight: '1200',
pixelWidth: '1600' }
Exiv2 also outputs these by default, along with the high level summary
exif tags.
Collaborator
|
This needs to be reworked to use NAN. I'd suggest skipping the filename since that's passed in. I've also been thinking about how we could pass in the file contents as a buffer or filename. In the case of reading from a buffer there would be no filename. The other properties seem like they'd work though. |
|
@drewish It looks like @bertrandom implemented reading/writing using @dberesford I'd love to see this PR updated to use NAN; I've also wanted to get this info along with the standard metadata tags. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Returns the following image properties (which are not tags but still very handy to have when processing images):
Exiv2 also outputs these by default, along with the high level summary exif tags.