Erc20 keeper extend #21
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neitdung
reviewed
Feb 25, 2025
| // TODO: these values were obtained from Remix using the ERC20.sol from OpenZeppelin. | ||
| // We should execute the transactions using the ERC20MinterBurnerDecimals.sol from Evmos testnet | ||
| // to ensure parity in the values. | ||
| switch method.Name { |
Member
There was a problem hiding this comment.
missing gas calculating for mint, burn
neitdung
reviewed
Feb 25, 2025
| accesses *ethtypes.AccessList, | ||
| ) *evmtypes.MsgEthereumTx { | ||
| chainID := suite.app.EvmKeeper.ChainID() | ||
| chainID := evmtypes.GetEthChainConfig().ChainID |
Member
There was a problem hiding this comment.
This is static value. We can change to this:
chainConfig, _ := suite.app.EvmKeeper.EVMConfig()
nonce := suite.app.EvmKeeper.GetNonce(
suite.ctx,
common.BytesToAddress(from.Bytes()),
)
data := make([]byte, 0)
gasLimit := uint64(100000)
args := evmtypes.EvmTxArgs{
Nonce: nonce,
GasLimit: gasLimit,
Input: data,
GasFeeCap: gasFeeCap,
GasPrice: gasPrice,
ChainID: chainConfig.ChainConfig.ChainID,
GasTipCap: gasTipCap,
Amount: nil,
To: &to,
Accesses: accesses,
}
neitdung
reviewed
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.