netsync: Limit manual request maps.#3687
Merged
davecgh merged 1 commit intodecred:masterfrom May 6, 2026
Merged
Conversation
jholdstock
approved these changes
May 5, 2026
dajohi
approved these changes
May 6, 2026
jrick
approved these changes
May 6, 2026
This applies the same request limits to manual requests as are applied to all of the netsync internal automatic request logic. The limiting mechanism this adds for manually requested transactions is intentionally slightly different than what is applied to the automatic request logic. In particular, the new additional manual request limiting only requests up to the max possible and ignores the rest. This distinction is made because the automatic code is more geared towards recency and has a variety of other logic that ultimately places stricter controls on the requests. On the other hand, manual requests are biased toward immediacy and have a larger theoretical attack surface.
davecgh
force-pushed
the
netsync_limit_manual_req_maps
branch
from
faa79d6 to
16e1f95
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This applies the same request limits to manual requests as are applied to all of the netsync internal automatic request logic.
The limiting mechanism this adds for manually requested transactions is intentionally slightly different than what is applied to the automatic request logic. In particular, the new additional manual request limiting only requests up to the max possible and ignores the rest.
This distinction is made because the automatic code is more geared towards recency and has a variety of other logic that ultimately places stricter controls on the requests. On the other hand, manual requests are biased toward immediacy and have a larger theoretical attack surface.