ui: start new user interface#3526
Open
buck54321 wants to merge 5 commits intodecred:masterfrom
Open
Conversation
buck54321
force-pushed
the
newui
branch
2 times, most recently
from
0203468 to
40f1137
Compare
Lays out the structure for the new React-based user interface. Implements wallet initialization sequence. Implements basic header and sidebar interface used for most views. Implements functionality related to forms and context management.
We don't have the convenience of Go templates with React, so this updates the internationalization scheme to do everything with Javascript. New translations are separated from old translations by the newui build tag, but a utility is added to import translations from the old set if there is a matching key-value pair in the new set.
ukane-philemon
suggested changes
Mar 29, 2026
Contributor
ukane-philemon
left a comment
ukane-philemon
left a comment
There was a problem hiding this comment.
Thank you @buck54321 for doing the ground work. I've gone through the changes and these are just a few things my eyes caught.
| } | ||
| } | ||
|
|
||
| func TestFiatRateSources(t *testing.T) { |
Contributor
There was a problem hiding this comment.
Any reason test was removed?
| } | ||
| }, []) | ||
|
|
||
| const usdBal = usdBalance |
Contributor
There was a problem hiding this comment.
No need to reassign usdBalance here.
All use of usdBal should be updated to usdBalance.
| const PasswordForm = ({ setRegistered, setUsingSeed, setSeed, seed }: PasswordFormParams) => { | ||
| const [pw, setPW] = useState('') | ||
| const [pw2, setPW2] = useState('') | ||
| const [err, setErr] = useState<string | undefined>(undefined) |
Contributor
There was a problem hiding this comment.
Should use string, not string | undefined. You can initialize to an empty string instead of undefined.
|
|
||
| export default function InitWizard ({ setInited }: InitWizardParams) { | ||
| const [usingSeed, setUsingSeed] = useState<boolean | undefined>(undefined) | ||
| const [seed, setSeed] = useState<string | undefined>(undefined) |
Contributor
There was a problem hiding this comment.
Same as my previous comment.
| </select> | ||
| <span className="ico-arrowdown fs8" /> | ||
| </div> | ||
|
|
| display: flex; | ||
| justify-content: center; | ||
| align-items: center; | ||
| } No newline at end of file |
| position: absolute; | ||
| top: 1rem; | ||
| right: 1rem; | ||
| } No newline at end of file |
|
|
||
| .ico-bell:before { | ||
| content: "\f417"; | ||
| } No newline at end of file |
| // @use "components.scss"; | ||
|
|
||
| // UI views | ||
| @use "main.scss"; No newline at end of file |
| // OK is worthless, because 'ok' is a getter on the fetch response in | ||
| // Javascript, so unless we return a 200, OK will be overwritten by True. | ||
| OK bool `json:"ok"` | ||
| Bad bool `json:"bad,omitempty"` |
Contributor
There was a problem hiding this comment.
DO we intend to keep both or remove Ok at some point?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lays out the structure for the new React-based user interface. Implements wallet initialization sequence. Implements basic header and sidebar interface used for most views. Implements functionality related to forms and context management.
Must build with
--tags newuibwnewui.mp4