Skip to content

Minor bugs in server/swap function processBlock #3587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jholdstock wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Minor bugs in server/swap function processBlock #3587

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
94ca39a
swap: Ensure processBlock evaluates all matches.
jholdstock Apr 4, 2026
7be48b1
swap: Don't defer mutex unlock in a loop.
jholdstock Apr 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions server/swap/swap.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1097,13 +1097,12 @@ func (s *Swapper) processBlock(ctx context.Context, block *blockNotification) {
// If it's neither of the match assets, nothing to do.
if match.makerStatus.swapAsset != block.assetID &&
match.takerStatus.swapAsset != block.assetID {
return
continue
}

// Lock the matchTracker so the following checks and updates are atomic
// with respect to Status.
match.mtx.RLock()
defer match.mtx.RUnlock()

switch match.Status {
case order.MakerSwapCast:
Expand All @@ -1127,6 +1126,8 @@ func (s *Swapper) processBlock(ctx context.Context, block *blockNotification) {
s.unlockOrderCoins(match.Taker)
}
}

match.mtx.RUnlock()
}
}

Expand Down
Loading