politeia: Fix proposal vote eligibility.#3588
Open
JoeGruffins wants to merge 1 commit intodecred:masterfrom
Open
politeia: Fix proposal vote eligibility.#3588JoeGruffins wants to merge 1 commit intodecred:masterfrom
JoeGruffins wants to merge 1 commit intodecred:masterfrom
Conversation
WalletProposalVoteDetails was passing only the already-voted ticket hashes to CommittedTickets, so it could never discover wallet tickets that had not yet voted. Fetch the full eligible ticket list from the vote snapshot via TicketVoteDetails and use that instead. Also restyle the vote modal to use standard form patterns (go/danger buttons, feature submit, consistent layout), hide the vote button after a successful vote, and log vote casts with ticket hashes.
ukane-philemon
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WalletProposalVoteDetails was passing only the already-voted ticket hashes to CommittedTickets, so it could never discover wallet tickets that had not yet voted. Fetch the full eligible ticket list from the vote snapshot via TicketVoteDetails and use that instead.
Also restyle the vote modal to use standard form patterns (go/danger buttons, feature submit, consistent layout), hide the vote button after a successful vote, and log vote casts with ticket hashes.