Don't block on channel send in oracle fee polling.#3590
Open
jholdstock wants to merge 1 commit intodecred:masterfrom
Open
Don't block on channel send in oracle fee polling.#3590jholdstock wants to merge 1 commit intodecred:masterfrom
jholdstock wants to merge 1 commit intodecred:masterfrom
Conversation
Because this channel send occurs without a timeout or non-blocking select fallback, a delay in the consuming goroutine which synchronously transmits the fees to connected WebSocket clients will lock the Oracle's execution thread indefinitely. A remote attacker can exploit this architectural flaw by initiating slow or locked WebSocket connections (e.g. Slow Loris), effectively paralyzing the server's global fee rate calculations and resulting in a Denial of Service. As the ticker-driven background Oracle loop should never be subject to downstream consumer availability, the channel send must be refactored to be non-blocking. This allows the Oracle to drop a broadcast instance under severe load to prioritize system health rather than failing globally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because this channel send occurs without a timeout or non-blocking select fallback, a delay in the consuming goroutine which synchronously transmits the fees to connected WebSocket clients will lock the Oracle's execution thread indefinitely. A remote attacker can exploit this architectural flaw by initiating slow or locked WebSocket connections (e.g. Slow Loris), effectively paralyzing the server's global fee rate calculations and resulting in a Denial of Service.
As the ticker-driven background Oracle loop should never be subject to downstream consumer availability, the channel send must be refactored to be non-blocking. This allows the Oracle to drop a broadcast instance under severe load to prioritize system health rather than failing globally.