Skip to content

Limit reads from untrusted sources #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jholdstock merged 1 commit into from
Apr 23, 2026
Merged

Limit reads from untrusted sources #206

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions service.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Copyright (c) 2017-2025 The Decred developers
// Copyright (c) 2017-2026 The Decred developers
// Use of this source code is governed by an ISC
// license that can be found in the LICENSE file.

Expand Down Expand Up @@ -190,7 +190,7 @@ func (service *Service) getHTTP(url string) ([]byte, error) {
url, poolResp.StatusCode)
}

respBody, err := io.ReadAll(poolResp.Body)
respBody, err := io.ReadAll(io.LimitReader(poolResp.Body, 1<<20)) // 1 MiB limit
if err != nil {
return nil, fmt.Errorf("%v: failed to read body: %w", url, err)
}
Expand Down
Loading