[WIP] politeiawww: Add auth plugin. #1630
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit performs some codebase organization and cleans up deadcode that was reported by `golangci-lint`. The `wsdcrdata` package is moved out of the main politeia directory and into `politeiawww`. The `unittest` package is moved out of the main politeia directory and into `util`.
This commit adds some additional error handling for when trillian unexpectedly fails, allowing the import command to continue without also failing. This edge case was encountered during testing.
This commit improves the error message that is returned when the expected number of blobs are not found in the key-value store. Previously, the keys that were not found were being included in the error message. This made the error message illegible when a large number of keys were being requested, like when all of a proposal's cast votes are being requested.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.