fix: use subprocess instead of os.system in data_analyzer.py#7994
Open
orbisai0security wants to merge 1 commit intodeepspeedai:masterfrom
Open
fix: use subprocess instead of os.system in data_analyzer.py#7994orbisai0security wants to merge 1 commit intodeepspeedai:masterfrom
orbisai0security wants to merge 1 commit intodeepspeedai:masterfrom
Conversation
Automated security fix generated by Orbis Security AI Signed-off-by: orbisai0security <mediratta01.pally@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix critical severity security issue in
deepspeed/runtime/data_pipeline/data_sampling/data_analyzer.py.Vulnerability
V-001deepspeed/runtime/data_pipeline/data_sampling/data_analyzer.py:75Description: The data_analyzer.py file uses os.system() with an f-string that directly interpolates the variable metric_to_sample_fname into a shell command without any sanitization. This variable is derived from user-supplied dataset configuration or file paths. Because os.system() invokes a shell interpreter, any shell metacharacters in the variable (semicolons, backticks, dollar signs, pipes, ampersands) will be interpreted and executed as separate shell commands.
Changes
deepspeed/runtime/data_pipeline/data_sampling/data_analyzer.pyVerification
Automated security fix by OrbisAI Security