feat: Add custom filter logic for stac-auth-proxy#388
Conversation
0bddf9d to
22ae95b
Compare
|
This requires stac-auth-proxy to support |
|
#386 should fix the failing tests. |
935b994 to
1b7e70b
Compare
|
I think a lot of the stuff should flow upstream: developmentseed/stac-auth-proxy#118 |
daf0427 to
ea0e1ae
Compare
…olumeMounts. (#114) Allows mounting custom filters in a kubernetes setup. Precondition for developmentseed/eoapi-k8s#388 Related: EOEPCA/resource-discovery#198 and IFRCGo/go-deploy#144
87f0c45 to
6346e1a
Compare
|
After implementing it upstream and adapting here to the new helm chart options, I ran into an important limitation: Files outside of a Helm application subchart, including those of the parent, cannot be accessed. This means we can't inject the So i cleaned it up, added a few tests and this is ready for review. |
e3d7f96 to
e2996aa
Compare
6f0a6fe to
25dc65d
Compare
|
|
||
| # Path to custom filters file (relative to chart root) | ||
| # When extraVolumes is configured, a ConfigMap will be created from this file | ||
| # customFiltersFile: "data/stac-auth-proxy/custom_filters.py" |
There was a problem hiding this comment.
So to make custom filters work I need to:
- Define the
customFiltersFile - Define
extraVolumesas specified in the commented out bits - Define
extraVolumeMountsas shown in the commented out example
Is that roughly accurate? Can we make that a bit more explicit in the docs, that you need to specify customFiltersFile and ALSO specify the extraVolumes and extraVolumeMounts for it to actually work?
I can see that this is slightly awkward for good reason, but I think we could some-how be a little bit clearer in the comments here - does that make sense?
If I'm misunderstanding and you don't actually need extraVolumes and extraVolumeMounts, then ignore this comment :)
There was a problem hiding this comment.
Yes, you are right, we need all three things.
And you are also right that this should be much better documented. I went over the documentation and tried to make things much clearer.
e2996aa to
4b37dc4
Compare
741e345 to
df55e35
Compare
Closes: #370
Related: EOEPCA/resource-discovery#198 and IFRCGo/go-deploy#144