Skip to content

Conversation

@michael-valdron
Copy link
Member

@michael-valdron michael-valdron commented Apr 13, 2025

Description of Changes

Replaces current devfile issue templates with GitHub issue forms to simplify and streamline issue creation.

Related Issue(s)

resolves #1141

Acceptance Criteria

New testing and documentation issues can be opened under devfile/api/issues.

You can check the respective criteria below if either of the following is true:

  • There is a separate tracking issue opened and that issue is linked in this PR.
  • Testing/documentation updates are contained within this PR.

If criteria is left unchecked please provide an explanation why.

Tests Performed

Used fork to test issue creation and form validation.

How To Test

Pull changes into fork and switch fork default branch to branch with changes, ensure issues on fork repository is enabled.

Ensure your fork has the labels you want to test, CI applied labels won't work in the fork

Notes To Reviewer

N/A

@michael-valdron
Copy link
Member Author

/area api

@openshift-ci openshift-ci bot added the area/api Enhancement or issue related to the api/devfile specification label Apr 17, 2025
@michael-valdron
Copy link
Member Author

/area ci, /area documentation

@openshift-ci openshift-ci bot added the area/documentation Improvements or additions to documentation label Apr 17, 2025
@openshift-ci
Copy link

openshift-ci bot commented Apr 17, 2025

@michael-valdron: The label(s) area/ci,, area//area cannot be applied, because the repository doesn't have them.

In response to this:

/area ci, /area documentation

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@michael-valdron michael-valdron removed area/documentation Improvements or additions to documentation area/api Enhancement or issue related to the api/devfile specification labels Apr 17, 2025
@michael-valdron
Copy link
Member Author

Will need to change the areas multi-choice dropdown to a textarea as putting the labeling commands separated by commas, a limitation with issue forms, will not trigger complete labeling as seen in my testing: #1703 (comment)

@michael-valdron
Copy link
Member Author

/area ci , /area api

@openshift-ci openshift-ci bot added area/ci area/api Enhancement or issue related to the api/devfile specification labels Apr 17, 2025
@openshift-ci
Copy link

openshift-ci bot commented Apr 17, 2025

@michael-valdron: The label(s) area/,, area//area cannot be applied, because the repository doesn't have them.

In response to this:

/area ci , /area api

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@michael-valdron michael-valdron removed area/api Enhancement or issue related to the api/devfile specification area/ci labels Apr 17, 2025
@michael-valdron
Copy link
Member Author

/area api, ci

@openshift-ci openshift-ci bot added the area/ci label Apr 17, 2025
@openshift-ci
Copy link

openshift-ci bot commented Apr 17, 2025

@michael-valdron: The label(s) area/api, cannot be applied, because the repository doesn't have them.

In response to this:

/area api, ci

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@michael-valdron
Copy link
Member Author

Will need to change the areas multi-choice dropdown to a textarea as putting the labeling commands separated by commas, a limitation with issue forms, will not trigger complete labeling as seen in my testing: #1703 (comment)

Adding spaces does the trick #1703 (comment), however it still produces an error not ideal every time an issue is created.

@michael-valdron michael-valdron marked this pull request as ready for review April 17, 2025 16:22
@michael-valdron michael-valdron requested review from a team, AObuchow and dkwon17 as code owners April 17, 2025 16:22
Copy link
Contributor

@Jdubrick Jdubrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few nits, also I can't open issues on your fork to see what each field is so if any suggestion doesn't make sense you can dismiss it (since I couldn't check)

@michael-valdron
Copy link
Member Author

also I can't open issues on your fork to see what each field is so if any suggestion doesn't make sense you can dismiss it (since I couldn't check)

@Jdubrick You'll need to pull changes into a branch in your fork and set it to the default if not already.

michael-valdron and others added 8 commits May 14, 2025 14:08
Target Odo Version

Co-authored-by: Jordan Dubrick <[email protected]>
Signed-off-by: Michael Valdron <[email protected]>
Expected Behavior

Co-authored-by: Jordan Dubrick <[email protected]>
Signed-off-by: Michael Valdron <[email protected]>
Additional Context

Co-authored-by: Jordan Dubrick <[email protected]>
Signed-off-by: Michael Valdron <[email protected]>
Feature Request

Co-authored-by: Jordan Dubrick <[email protected]>
Signed-off-by: Michael Valdron <[email protected]>
Additional Context

Co-authored-by: Jordan Dubrick <[email protected]>
Signed-off-by: Michael Valdron <[email protected]>
Issue Details

Co-authored-by: Jordan Dubrick <[email protected]>
Signed-off-by: Michael Valdron <[email protected]>
Emergency Registry Update

Co-authored-by: Jordan Dubrick <[email protected]>
Signed-off-by: Michael Valdron <[email protected]>
Request Details

Co-authored-by: Jordan Dubrick <[email protected]>
Signed-off-by: Michael Valdron <[email protected]>
…e with devfile/devfile-registry-maintainers as the default value

Signed-off-by: Michael Valdron <[email protected]>
@michael-valdron
Copy link
Member Author

@thepetk @Jdubrick Wanted to follow up if everything looks good and we are ready to merge this PR.

Copy link
Contributor

@thepetk thepetk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@michael-valdron
Copy link
Member Author

@AObuchow @dkwon17 Do these changes look good to you both?

@michael-valdron
Copy link
Member Author

@AObuchow @dkwon17 Do these changes look good to you both?

@AObuchow @dkwon17 Just wanted to follow up to see if either of you had a chance to review the new issue forms changes?

@dkwon17
Copy link

dkwon17 commented Jul 14, 2025

@michael-valdron I have one suggestion above, otherwise LGTM

@openshift-ci openshift-ci bot removed the lgtm label Jul 14, 2025
@michael-valdron michael-valdron requested a review from dkwon17 July 14, 2025 21:41
@openshift-ci
Copy link

openshift-ci bot commented Jul 14, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dkwon17, Jdubrick, michael-valdron, thepetk

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@michael-valdron michael-valdron merged commit 22851c4 into devfile:main Jul 14, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[meta] Clean up issue templates in this repository

4 participants