feat: no state hashing during catch-up (consensus) #8232
+155
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mraszyk
commented
Jan 6, 2026
mraszyk
commented
Jan 6, 2026
mraszyk
commented
Jan 6, 2026
This comment was marked as resolved.
This comment was marked as resolved.
mraszyk
commented
Jan 9, 2026
mraszyk
commented
Jan 12, 2026
mraszyk
commented
Jan 12, 2026
mraszyk
force-pushed
the
mraszyk/optimized-node-catch-up
branch
from
26af951 to
4d31366
Compare
mraszyk
changed the base branch from
master
to
mraszyk/no-state-hashing-during-catchup
mraszyk
changed the title
eichhorl
reviewed
Feb 3, 2026
Comment on lines
+194
to
+196
| .list_state_heights_to_certify() | ||
| .into_iter() | ||
| .filter(|height| !deliver_state_certification(*height)) |
Contributor
There was a problem hiding this comment.
Is it guaranteed that the view of both list_... functions is consistent? Or could it happen that the same height appears in both lists?
eichhorl
reviewed
Feb 3, 2026
| @@ -148,29 +174,12 @@ impl<T: CertificationPool> PoolMutationsProducer<T> for CertifierImpl { | |||
| .list_state_hashes_to_certify() | |||
| .into_iter() | |||
| .filter_map(|(height, hash, witness)| { | |||
Contributor
There was a problem hiding this comment.
Maybe this should also be filter instead?
Suggested change
| .filter_map(|(height, hash, witness)| { | |
| .filter(|(height, hash, witness)| { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes consensus (certifier) poll the state manager’s method
list_state_heights_to_certifyto learn which heights are requested to be (optimistically) certified in advance (before DSM catches up to compute their corresponding states). The consensus certifier attempts to deliver a certification for every such height (using the existing methodStateManager::deliver_state_certification) if available and aggregates/validates certifications for those heights.