fix:hot-fix pdfgui functionality fix after skpkg#298
fix:hot-fix pdfgui functionality fix after skpkg#298stevenhua0320 wants to merge 1 commit intodiffpy:mainfrom
Conversation
|
Please can you check? This seems to be failing tests. Done version compatibility on problem? |
Ah, I read the full comment above, my apologies. I will merge this. |
|
actually, let's go a bit more slowly. Let's finalize the release of pdffit2 (please see the issue over there), push out that full release and rerun the action here so it passes, then I will merge. |
|
As we have released the new version of both |
|
@stevenhua0320 please see the message in slack. I couldn't merge |
|
actually, I will have to merge it, but if you can get it passing tests I can do it. We may have to update the code in the pdffit2 itself to fix it, but hopefully it is changing how the tests are run in CF to fix it. Please make your own PR and work on that. |
I have seen your PR on the feedstock on that. Let me first inspect where the issue is! |
@sbillinge ready to review. We have done the skpkg for this without waiting for its dependency new version release and we merged that PR. But today when I ran it using the developer version of
diffpy.pdfgui, it gives me a lot of errors other than the python version. So, I made this PR to fix all of these.__date__variable inaboutdialog.pysince it is the only place that we need the__date__. This helps us to run thepytestsucessfully.os.pathtoPath()object to comply with the group standard.pyproject.toml, this is needed because in theskpkgit changes the actual script running thepdfgui. Therefore, I changed it back to the application and in order to comply with the name of the app in the tutorial, I also changed the name of the command fromdiffpy-pdfguiback topdfgui.After finishing up these, I ran the
pytestand also running the app, it works properly now. The CI would still failing since dependecies haven't updated to3.14yet, but now local test would confirm that everything is right now.