feat: NeutronSQNode unit tests #2301
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trisyoungs
force-pushed
the
dissolve2/sq-unit-tests
branch
from
cbd164f to
5007eaa
Compare
trisyoungs
force-pushed
the
dissolve2/neutronsq-unit-tests
branch
from
61e6104 to
8250a66
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #2300 - do not merge until #2300 is resolved
This PR adds unit tests for the
NeutronSQNode. One relatively significant change is the way that we now must handle our lists of exchangeable atom types. Previously this was defined as a very literal vector ofAtomType*but here the preference is to move to a simple list of atom type names. The reason for that is that multiple species may contain atom types of the same name while not explicitly sharing data through the pointer - a name will capture all such occurrences of a given atom type. This may of course be subject to change as we move forward!