Update scaling to ensure parity with dotnet output#29
Open
donaldgray wants to merge 1 commit intomasterfrom
Open
Update scaling to ensure parity with dotnet output#29donaldgray wants to merge 1 commit intomasterfrom
donaldgray wants to merge 1 commit intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In production use, noticed that there are differences between the sizes calculated by the
iiif-netdotnet library used by Protagonist and the sizes calculated by Appetiser.Altered the
scaled_dimensions_to_fit()function to use method from "old" Appetiser equivalent function https://github.com/dlcs/appetiser/blob/1.5.0/app/jp2/image.py#L218-L241 and used similar handling to dotnet code forw,and,h.For reference the dotnet lib functions are:
w,and,h)!w,h).Note
How can we extend the test suite to allow us to test this function to ensure any future changes don't break anything (e.g. if we allow mutating size-parameters?
@tomcrane conducted some tests: https://github.com/tomcrane/appetiserscale/blob/main/8-b-numbers.txt to check fix, based on https://github.com/tomcrane/appetiserscale/blob/main/test.py#L80