Migration for OpenFullMax and MaxWidth#1103
Closed
donaldgray wants to merge 3 commits intodevelopfrom
Closed
Conversation
JackLewis-digirati
approved these changes
Feb 6, 2026
These 2 values will supersede MaxUnauthorised so migration contains UPDATE script for setting new fields appropriately.
Remove and re-add as there was a migration introduced to dev. Also changed to use not-null integer values for consistency and ease of implementing API (for historical reasons the logic assumes there are no null values so implemmentation is simplified if this is the case)
donaldgray
force-pushed
the
feature/replace_maxunauth
branch
from
bf503aa to
02f4673
Compare
Member
Author
|
Closing PR - the change to make |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These 2 values will supersede MaxUnauthorised so migration contains UPDATE script for setting new fields appropriately.
PR contains migration only - these are not used in application. UPDATE statement based on https://github.com/dlcs/protagonist/blob/develop/docs/adr/0010-replace-maxunauthorised.md#use-case--behaviours
Below shows a table of the different permutations of MaxUnauthorised/Role and how they are transformed to OpenFullMax/Role (MaxWidth will be
nullin all instances). Note that the "classification" value is from update statement:Warning
Contains a migration. New columns in "Images" and UPDATE statement.
This could be slow / expensive in some environments!
Resolves #1092