Add sequential inter-record Rhai helpers: prev/lag/delta/ewma#162
Open
Add sequential inter-record Rhai helpers: prev/lag/delta/ewma#162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
src/rhai_functions/inter_record.rsthat providesprev,lag,delta,ewmaand strict variants with validation (n >= 1,n <= 10_000,alpha in (0,1]), native-numericdeltasemantics, and explicit--parallelmode errors using thread-local state.clear_current_eventon script errors (src/pipeline/mod.rs).src/runner.rs,src/parallel/worker.rs).src/rhai_functions/mod.rs) and added help/docs entries and reference text describing semantics and lifecycle (src/rhai_functions/docs.rs,docs/reference/functions.md,docs/reference/script-variables.md).tests/inter_record_integration_test.rsand unit tests inside the module to cover history progression, filtered-event advancement, EWMA, contract validation, and explicit--parallelerror behavior.Testing
cargo fmt --allsuccessfully to format code.cargo clippy --all-targets --all-features -- -D warningssuccessfully with no warnings.cargo test, which completed successfully (all tests passed).cargo test rhai_functions::inter_record::tests::prev_and_lag_follow_history -- --nocaptureandcargo test --test inter_record_integration_test, both of which passed.Codex Task