[Graphbolt] [NFC] Remove default backend torch.distributed.init_process_group calls #7870
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See pytorch/pytorch#147631 With newer torch versions, the behavior in these locations was changed from initializing nccl+gloo to only initializing gloo. The changed test relies on both backends existing and would fail on newer torch versions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With newer pytorch versions, the behavior in these locations was changed from initializing nccl+gloo to only initializing nccl.
Now, all locations explicitly specify their desired backends. These additions maintain expected torch<=2.4 behavior on torch>=2.6. The changed test relies on both backends existing and would fail on newer torch versions.
See pytorch/pytorch#147631