Fix RET file navigation in tool output blocks#135
Merged
Conversation
- use diff context line numbers for edit navigation - map read/custom tool lines correctly in collapsed vs expanded views - stop falling back to line 1 on non-content lines - support path-based syntax fences for generic tools with :path - refactor and extend visit-file tests (including C-u RET) and update README
e484251 to
ab2689f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed for users
This PR fixes incorrect
RETfile navigation from tool output in the chat buffer.✅ Fixed behaviors
readoutput now navigates to the correct file line in both collapsed and expanded views, including output that contains blank lines.RETon non-content collapsed lines (closing fence and... (N more lines)) now reports a clear error instead of jumping to line 1.editdiff navigation now supports added (+), removed (-), and context () rows.:pathnow mapsRETnavigation correctly in expanded and collapsed views.:pathnow uses extension-based syntax fences (same behavior as built-in file tools).:offsetis applied only toread(as intended) and ignored forwrite.Docs and tests
RETbehavior in tool blocks.C-u RETinversion (same-windowopen path).Verification
make check: